Skip to content

Allow compatibility in skill frontmatter validation #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khanukov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow compatibility in skill frontmatter validation #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion skills/.system/skill-creator/scripts/quick_validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import yaml

MAX_SKILL_NAME_LENGTH = 64
MAX_COMPATIBILITY_LENGTH = 500


def validate_skill(skill_path):
Expand Down Expand Up @@ -37,7 +38,7 @@ def validate_skill(skill_path):
except yaml.YAMLError as e:
return False, f"Invalid YAML in frontmatter: {e}"

allowed_properties = {"name", "description", "license", "allowed-tools", "metadata"}
allowed_properties = {"name", "description", "license", "allowed-tools", "metadata", "compatibility"}

unexpected_keys = set(frontmatter.keys()) - allowed_properties
if unexpected_keys:
Expand Down Expand Up @@ -88,6 +89,23 @@ def validate_skill(skill_path):
f"Description is too long ({len(description)} characters). Maximum is 1024 characters.",
)

if "compatibility" in frontmatter:
compatibility = frontmatter.get("compatibility", "")
if not isinstance(compatibility, str):
return (
False,
f"Compatibility must be a string, got {type(compatibility).__name__}",
)
compatibility = compatibility.strip()
if not compatibility:
return False, "Compatibility cannot be empty"
if len(compatibility) > MAX_COMPATIBILITY_LENGTH:
return (
False,
f"Compatibility is too long ({len(compatibility)} characters). "
f"Maximum is {MAX_COMPATIBILITY_LENGTH} characters.",
)

return True, "Skill is valid!"


Expand Down