KEYS: asymmetric: Copy sig and digest in public_key_verify_signature() #222
+21
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit ac4e97a ("scatterlist: sg_set_buf() argument must be in linear mapping") checks that both the signature and the digest reside in the linear mapping area. However, more recently commit ba14a19 ("fork: Add generic vmalloced stack support") made it possible to move the stack in the vmalloc area, which is not contiguous, and thus not suitable for sg_set_buf() which needs adjacent pages. Always make a copy of the signature and digest in the same buffer used to store the key and its parameters, and pass them to sg_init_one(). Prefer it to conditionally doing the copy if necessary, to keep the code simple. The buffer allocated with kmalloc() is in the linear mapping area. Cc: [email protected] # 4.9.x Fixes: ba14a19 ("fork: Add generic vmalloced stack support") Link: https://lore.kernel.org/linux-integrity/[email protected]/ Suggested-by: Eric Biggers <[email protected]> Signed-off-by: Roberto Sassu <[email protected]> Reviewed-by: Eric Biggers <[email protected]> Tested-by: Stefan Berger <[email protected]>
|
This particular patch has now been merged upstream: torvalds@c3d03e8 I need this patch for proper EVM signature enforcement and will drop it from my OpenBMC series of patches once the OpenBMC Linux build includes this patch. I have been carrying this patch here lately: https://gerrit.openbmc.org/c/openbmc/openbmc/+/63909 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ac4e97a ("scatterlist: sg_set_buf() argument must be in linear mapping") checks that both the signature and the digest reside in the linear mapping area.
However, more recently commit ba14a19 ("fork: Add generic vmalloced stack support") made it possible to move the stack in the vmalloc area, which is not contiguous, and thus not suitable for sg_set_buf() which needs adjacent pages.
Always make a copy of the signature and digest in the same buffer used to store the key and its parameters, and pass them to sg_init_one(). Prefer it to conditionally doing the copy if necessary, to keep the code simple. The buffer allocated with kmalloc() is in the linear mapping area.
Cc: [email protected] # 4.9.x
Fixes: ba14a19 ("fork: Add generic vmalloced stack support")
Link: https://lore.kernel.org/linux-integrity/[email protected]/
Suggested-by: Eric Biggers [email protected]
Reviewed-by: Eric Biggers [email protected]
Tested-by: Stefan Berger [email protected]