Skip to content

feat: add hover effect to skill and plugin cards #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinw-openai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add hover effect to skill and plugin cards #1356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1642,6 +1642,29 @@ code {
.skill-card {
min-height: 176px;
box-shadow: 0 1px 3px rgba(42, 31, 25, 0.08);
transition:
transform 0.2s ease,
box-shadow 0.2s ease,
border-color 0.2s ease,
background 0.2s ease;
}
Comment on lines +1648 to +1650
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unused background transition property

background 0.2s ease is listed in the transition shorthand, but none of the hover or focus-within rules actually change the background color. This means the property is transitioning nothing and can be removed to keep the declaration clean.

Suggested change
border-color 0.2s ease,
background 0.2s ease;
}
transition:
transform 0.2s ease,
box-shadow 0.2s ease,
border-color 0.2s ease;
Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/styles.css
Line: 1648-1650

Comment:
**Unused `background` transition property**

`background 0.2s ease` is listed in the transition shorthand, but none of the hover or focus-within rules actually change the background color. This means the property is transitioning nothing and can be removed to keep the declaration clean.

```suggestion
  transition:
    transform 0.2s ease,
    box-shadow 0.2s ease,
    border-color 0.2s ease;
```

How can I resolve this? If you propose a fix, please make it concise.


.skill-card:hover,
.skill-card:focus-within {
border-color: var(--border-ui-hover);
transform: translateY(-1px);
box-shadow: 0 10px 20px rgba(29, 26, 23, 0.12);
}

.skill-card:focus-visible {
outline: 3px solid rgba(255, 107, 74, 0.3);
outline-offset: 3px;
}

[data-theme="dark"] .skill-card:hover,
[data-theme="dark"] .skill-card:focus-within {
border-color: var(--border-ui-hover);
box-shadow: 0 14px 28px rgba(7, 15, 20, 0.36);
}
Comment on lines +1664 to 1668
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Redundant border-color declaration in dark-theme override

border-color: var(--border-ui-hover) is already set by the base .skill-card:hover, .skill-card:focus-within rule above. Because CSS custom properties are resolved at computed time, the variable will automatically pick up whatever value [data-theme="dark"] defines for --border-ui-hover. Repeating the same declaration here is a no-op — only the box-shadow override is needed.

Suggested change
[data-theme="dark"] .skill-card:hover,
[data-theme="dark"] .skill-card:focus-within {
border-color: var(--border-ui-hover);
box-shadow: 0 14px 28px rgba(7, 15, 20, 0.36);
}
[data-theme="dark"] .skill-card:hover,
[data-theme="dark"] .skill-card:focus-within {
box-shadow: 0 14px 28px rgba(7, 15, 20, 0.36);
}
Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/styles.css
Line: 1664-1668

Comment:
**Redundant `border-color` declaration in dark-theme override**

`border-color: var(--border-ui-hover)` is already set by the base `.skill-card:hover, .skill-card:focus-within` rule above. Because CSS custom properties are resolved at computed time, the variable will automatically pick up whatever value `[data-theme="dark"]` defines for `--border-ui-hover`. Repeating the same declaration here is a no-op — only the `box-shadow` override is needed.

```suggestion
[data-theme="dark"] .skill-card:hover,
[data-theme="dark"] .skill-card:focus-within {
  box-shadow: 0 14px 28px rgba(7, 15, 20, 0.36);
}
```

How can I resolve this? If you propose a fix, please make it concise.


.skill-card-tags {
Expand Down