fix: harden production deploy smoke coverage#1523
fix: harden production deploy smoke coverage#1523Sheygoodbai wants to merge 1 commit intoopenclaw:mainfrom
Conversation
|
@Sheygoodbai is attempting to deploy a commit to the 0xBuns Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR hardens the production deploy pipeline by inserting an HTTP smoke step before the UI smoke, adding 429-retry logic with header-aware back-off, memoizing the skill-detail API call across tests, and extending the Playwright suite with signed-out publish/import coverage. The Confidence Score: 5/5PR is safe to merge; all findings are minor style suggestions. The only finding is unreachable dead code in the fetchWithRetry post-loop block — a cleanup-only concern with zero effect on correctness or reliability. All other changes are straightforward smoke-coverage improvements. No files require special attention. Prompt To Fix All With AIThis is a comment left during a code review.
Path: e2e/prod-http-smoke.e2e.test.ts
Line: 81-85
Comment:
**Unreachable dead code after loop**
The `if (!lastResponse)` guard and `return lastResponse` are unreachable. On the final iteration (`attempt === MAX_RATE_LIMIT_RETRIES - 1`), line 76 always `return`s the 429 response before the `for` loop can exit naturally, so execution never reaches line 81. The post-loop block can be safely removed.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix: harden production deploy smoke cove..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| if (!lastResponse) { | ||
| throw new Error("Expected a response while retrying rate-limited request."); | ||
| } | ||
|
|
||
| return lastResponse; |
There was a problem hiding this comment.
The if (!lastResponse) guard and return lastResponse are unreachable. On the final iteration (attempt === MAX_RATE_LIMIT_RETRIES - 1), line 76 always returns the 429 response before the for loop can exit naturally, so execution never reaches line 81. The post-loop block can be safely removed.
Prompt To Fix With AI
This is a comment left during a code review.
Path: e2e/prod-http-smoke.e2e.test.ts
Line: 81-85
Comment:
**Unreachable dead code after loop**
The `if (!lastResponse)` guard and `return lastResponse` are unreachable. On the final iteration (`attempt === MAX_RATE_LIMIT_RETRIES - 1`), line 76 always `return`s the 429 response before the `for` loop can exit naturally, so execution never reaches line 81. The post-loop block can be safely removed.
How can I resolve this? If you propose a fix, please make it concise.1 participant
Summary
Verification