Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

round generation values #121

Merged
merged 1 commit into from
Sep 7, 2023
Merged

round generation values #121

merged 1 commit into from
Sep 7, 2023

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Sep 7, 2023

Pull Request

Description

round api generation values
Helps with #102

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #121 (144d7eb) into main (5c7d1a3) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   94.46%   94.47%   +0.01%     
==========================================
  Files          11       11              
  Lines         542      543       +1     
==========================================
+ Hits          512      513       +1     
  Misses         30       30              
Files Changed Coverage Δ
pv_site_api/__init__.py 100.00% <100.00%> (ø)
pv_site_api/convert.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peterdudfield peterdudfield merged commit 3d89f80 into main Sep 7, 2023
@peterdudfield peterdudfield deleted the round branch September 7, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant