-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create datapipe for resampled format #6
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a datapipe or conversion script here for the raw data to netCDF? I see the stuff from the other PR here, but yeah, I'd recommend not requesting a review till the code is ready to go. And maybe split out the common changes between this PR and #5 into a smaller PR of its own, so the changes aren't duplicated, and its easier to tell what the changes are.
.flake8
Outdated
@@ -0,0 +1,2 @@ | |||
[flake8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these more util=y kinda ones, especially since they are the same between this PR and the other one, I would make them its own PR and merge that instead, so this PR is just focused on the datapipe bit, and not the extra formatting bits.
Sure, sorry about that, I'll do that right away! |
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
=======================================
Coverage ? 97.22%
=======================================
Files ? 3
Lines ? 36
Branches ? 0
=======================================
Hits ? 35
Misses ? 1
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! One thing with the DataArray, just for naming the dimensions to match what we use in other NetCDF files, but yeah, looking good!
Pull Request
Description
Creating data pipes to for the resampled format of the Solar farm data
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: