Skip to content

Avoid frozen-string-literal warnings in Ruby 3.4 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kindjar wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Avoid frozen-string-literal warnings in Ruby 3.4 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cf5f42
Clean up subs files after shortcut test
kindjar Apr 9, 2026
13c51da
Replace literals that get modified w/ String.new
kindjar Apr 9, 2026
19784ee
Add frozen-string pragma to files
kindjar Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/webvtt.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# encoding: UTF-8
# frozen_string_literal: true

if defined?(Encoding)
Encoding.default_internal = Encoding.default_external = "UTF-8"
Expand Down
4 changes: 3 additions & 1 deletion lib/webvtt/parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module WebVTT

def self.read(file)
Expand Down Expand Up @@ -118,7 +120,7 @@ def self.parse(cue)
end

def to_webvtt
res = ""
res = String.new
if @identifier
res << "#{@identifier}\n"
end
Expand Down
2 changes: 2 additions & 0 deletions lib/webvtt/segmenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'fileutils'

module WebVTT
Expand Down
4 changes: 3 additions & 1 deletion tests/parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

$LOAD_PATH << "lib/"
require "minitest/autorun"
require "webvtt"
Expand Down Expand Up @@ -257,7 +259,7 @@ def test_build_cue
cue.start = WebVTT::Timestamp.new 0
cue.end = WebVTT::Timestamp.new 12
cue.text = "Built from scratch"
output = ""
output = String.new
output << "00:00:00.000 --> 00:00:12.000\n"
output << "Built from scratch"
assert_equal output, cue.to_webvtt
Expand Down
6 changes: 5 additions & 1 deletion tests/segmenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

$LOAD_PATH << "lib/"
require "minitest/autorun"
require "webvtt"
Expand Down Expand Up @@ -53,9 +55,11 @@ def test_shortcut_method
res = WebVTT.segment("tests/subtitles/test.vtt")
assert_instance_of Array, res
assert_equal 2, res.size
assert_equal 35, res[1].size
subs = res[1]
assert_equal 35, subs.size

# clean up
subs.each {|f| FileUtils.rm(f.filename)}
FileUtils.rm("prog_index.m3u8")
end

Expand Down