-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add memory policy support #4726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
66df434
to
cde25df
Compare
@AkihiroSuda, @giuseppe, do you think it would be good to keep this PR as Draft until opencontainers/runtime-spec#1282 is merged? Or should I make it Ready for review (despite the "replace" in go.mod) in order to get reviews and possibly get this tagged into v1.3? |
Please keep this draft until the runtime spec PR gets merged |
26ab8a1
to
3bb9611
Compare
22c31a6
to
e5dca5d
Compare
@AkihiroSuda, as the memory policy field is now in place in the runtime-spec (opencontainers/runtime-spec#1282 merged), I updated this PR to use the latest runtime-spec and removed the Draft status. Rebased and fixed lint issues. Good for review now. :) |
Careful with the milestones. According to the new release policy, features should by merged by rc1, which is due by the end of the month. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your great code. I have two questions — please see the review comments.
e5dca5d
to
c0e7e4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just two minor questions—neither is critical for this PR.
This is marked for 1.4.0 but I plan to cut -rc1 this week and there are still some outstanding points. Do we want to merge this as-is and fix it in -rc2 or punt it for 1.5.0 (to be released in April 2026)? |
IMHO let's continue with the plans to release rc.1. If this is ready before that, we include it, otherwise we then decide if we want to merge and polish during the rc phase or just wait for 1.5. |
b58fe51
to
bed8a2c
Compare
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282 Signed-off-by: Antti Kervinen <[email protected]>
bed8a2c
to
b9d49e6
Compare
Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282