Skip to content

Conversation

askervin
Copy link
Contributor

@askervin askervin commented Apr 16, 2025

Implement support for Linux memory policy in OCI spec PR: opencontainers/runtime-spec#1282

@askervin askervin force-pushed the 5aD-oci-mempolicy branch 10 times, most recently from 66df434 to cde25df Compare April 22, 2025 06:48
@askervin askervin changed the title [DO NOT MERGE] Add memory policy support Add memory policy support Apr 22, 2025
@askervin
Copy link
Contributor Author

@AkihiroSuda, @giuseppe, do you think it would be good to keep this PR as Draft until opencontainers/runtime-spec#1282 is merged? Or should I make it Ready for review (despite the "replace" in go.mod) in order to get reviews and possibly get this tagged into v1.3?

@AkihiroSuda
Copy link
Member

Please keep this draft until the runtime spec PR gets merged

@askervin askervin force-pushed the 5aD-oci-mempolicy branch 4 times, most recently from 26ab8a1 to 3bb9611 Compare April 23, 2025 07:36
@askervin askervin force-pushed the 5aD-oci-mempolicy branch 2 times, most recently from 22c31a6 to e5dca5d Compare August 5, 2025 14:33
@askervin askervin marked this pull request as ready for review August 5, 2025 14:55
@askervin
Copy link
Contributor Author

askervin commented Aug 5, 2025

@AkihiroSuda, as the memory policy field is now in place in the runtime-spec (opencontainers/runtime-spec#1282 merged), I updated this PR to use the latest runtime-spec and removed the Draft status. Rebased and fixed lint issues. Good for review now. :)

@h-vetinari
Copy link

Careful with the milestones. According to the new release policy, features should by merged by rc1, which is due by the end of the month.

@AkihiroSuda AkihiroSuda requested a review from a team August 24, 2025 01:35
Copy link
Member

@lifubang lifubang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great code. I have two questions — please see the review comments.

Copy link
Member

@lifubang lifubang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just two minor questions—neither is critical for this PR.

@cyphar
Copy link
Member

cyphar commented Sep 3, 2025

This is marked for 1.4.0 but I plan to cut -rc1 this week and there are still some outstanding points. Do we want to merge this as-is and fix it in -rc2 or punt it for 1.5.0 (to be released in April 2026)?

@rata
Copy link
Member

rata commented Sep 3, 2025

IMHO let's continue with the plans to release rc.1. If this is ready before that, we include it, otherwise we then decide if we want to merge and polish during the rc phase or just wait for 1.5.

@askervin askervin force-pushed the 5aD-oci-mempolicy branch 2 times, most recently from b58fe51 to bed8a2c Compare September 4, 2025 12:18
Implement support for Linux memory policy in OCI spec PR:
opencontainers/runtime-spec#1282

Signed-off-by: Antti Kervinen <[email protected]>
@askervin askervin requested a review from cyphar September 4, 2025 12:47
@cyphar cyphar modified the milestones: 1.4.0, 1.4.0-rc.2 Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants