Switch to Go 1.24 as a min version, bump CI, modernize sources #4851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
rata
reviewed
Aug 18, 2025
|
@kolyshkin there are conflicts, but after that auto-merge I guess should work :) |
This is not needed since commit 16d7336 which sets 1.23 to be a minimally required Go version. Signed-off-by: Kir Kolyshkin <[email protected]>
Now that Go 1.25 is out, let's switch to go 1.24.0 as a minimally supported version, drop Go 1.23 and add Go 1.25 to CI matrix. Signed-off-by: Kir Kolyshkin <[email protected]>
In these cases, omitempty doesn't really work so it is useless, but omitzero actually works. As a result, output of `runc events` may omit these fields if all they contain are zeroes. NOTE this might be a breaking change. Signed-off-by: Kir Kolyshkin <[email protected]>
Brought to you by modernize -fix -test ./... Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details. High level overview:
Similar cgroups PR: opencontainers/cgroups#28