feat(email-sdk): support CommonJS require - #169
Draft
leoisadev1 wants to merge 1 commit into
Draft
Conversation
Expose the existing synchronous ESM output to both module loaders so modern Node CommonJS applications can require every public entry point without a duplicate build. Test the packed package through CommonJS under Node and Bun, and document the Node 20.19 minimum for require(). Fixes #161
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CommonJS applications cannot resolve the SDK because its export map only matches ESM imports. Node.js 20.19 and newer can load this synchronous ESM graph with
require(), so the package does not need a second build.What changed
Testing
bun run release:cibunx oxlint scripts/check-package-tarballs.tsFixes #161