map prompt for duplicate creation #222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wine93
reviewed
May 9, 2023
| @@ -76,6 +77,13 @@ func NewCreateVolumeTask(curveadm *cli.CurveAdm, cc *configure.ClientConfig) (*t | |||
| subname := fmt.Sprintf("hostname=%s image=%s", hc.GetHostname(), cc.GetContainerImage()) | |||
| t := task.NewTask("Create Volume", subname, hc.GetSSHConfig()) | |||
|
|
|||
| if len(cc.GetContainerImage()) == 0 { | |||
There was a problem hiding this comment.
Actually, there is a default value for client container image, so maybe it's an useless branch. AND:
- you should add a step to do checking, maybe
step.Lambais a good choice. - what is the purpose of those changes.
tsonglew
reviewed
May 14, 2023
| if err != nil { | ||
| return t, nil | ||
| } | ||
| } else { |
There was a problem hiding this comment.
We should prompt based on the actual volume size and the expected, rather than the container image.
|
@mfordjody anything changed? |
I am currently unable to conduct testing because I have encountered the above situation @caoxianfei1 |
you can delete the container and retry it. |
map prompt for duplicate creation Signed-off-by: mfordjody <[email protected]> commented code Signed-off-by: mfordjody <[email protected]> restore commit add image status
|
Requires longer modification time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.