Skip to content

With Geomad and LESS ram for integration tests#210

Open
omad wants to merge 9 commits intodevelopfrom
geomad-2
Open

With Geomad and LESS ram for integration tests#210
omad wants to merge 9 commits intodevelopfrom
geomad-2

Conversation

@omad
Copy link
Copy Markdown
Member

@omad omad commented Sep 7, 2025

See #207, this is that, but with lowered RAM usage allowed in GHA.

From my comment #207 (comment)

That memory limit argument is used to tell dask how much memory it is allowed to use (and maybe to work out chuck sizes, I'm not sure).

I think GitHub actions runners have 16GB of RAM, so dask needs to use substantially less to not be killed.

The log messages from dask in the failed runs indicated it had decided to use about 14GB, so it must use a heuristic that assumes it can use most of the available ram, too much in this case.

@omad omad requested a review from SpacemanPaul September 7, 2025 22:40
@SpacemanPaul
Copy link
Copy Markdown
Contributor

🤞

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.52%. Comparing base (5b85e93) to head (1fec3d5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #210   +/-   ##
========================================
  Coverage    81.52%   81.52%           
========================================
  Files           53       53           
  Lines         4849     4849           
========================================
  Hits          3953     3953           
  Misses         896      896           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

omad added 2 commits September 8, 2025 09:27
The memory limit argument is used to tell dask how much memory it is allowed to use (and maybe to work out chuck sizes, I'm not sure).

I think GitHub actions runners have 16GB of RAM, so dask needs to use substantially less to not be killed.

The log messages from dask in the failed runs indicated it had decided to use about 14GB, so it must use a heuristic that assumes it can use most of the available ram, too much in this case.
…d restricting the bands used for the geomedian integration test
@omad omad force-pushed the geomad-2 branch 2 times, most recently from a3a1b97 to 90431de Compare September 8, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants