Use leader election for better compatibility with in-place upgrades (#…

…492) * Revert "Better compatibility with in-place upgrades (#491)" This reverts commit 2a917ea. * Use leader election for better compatibility with in-place upgrades The previous commit reverts 2a917e, which changed the configuration of the Deployment for the manager to use `Recreate` strategy. Such change was for better compatibility for in-place upgrades (see the commit message of the reverted one). Instead of changing the Deployment strategy, this commit is enabling leader election in the manager. The leader election also solves the issues mentioned in commit 2a917e. Also, not changing the Deployment strategy works better with odh-operator. Signed-off-by: Edgar Hernández <[email protected]> --------- Signed-off-by: Edgar Hernández <[email protected]>
opendatahub-io · Feb 11, 2025 · 5bfa8ea · 5bfa8ea
1 parent 2a917ea
commit 5bfa8ea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/config/default/manager_auth_proxy_patch.yaml b/config/default/manager_auth_proxy_patch.yaml
@@ -31,4 +31,3 @@ spec:
       - name: manager
         args:
         - "--metrics-addr=127.0.0.1:8080"
-        - "--leader-elect"
diff --git a/config/manager/manager.yaml b/config/manager/manager.yaml
@@ -12,9 +12,6 @@ spec:
     matchLabels:
       control-plane: kserve-controller-manager
       controller-tools.k8s.io: "1.0"
-  strategy:
-    type: Recreate
-    rollingUpdate: nil
   template:
     metadata:
       labels:
@@ -30,6 +27,8 @@ spec:
       containers:
       - command:
         - /manager
+        args:
+        - "--leader-elect"
         image: ko://github.com/kserve/kserve/cmd/manager
         imagePullPolicy: Always
         name: manager