NO-JIRA: ci(.tekton/): remove obsolete sbom-syft-generate step override - #4569
Merged
Conversation
Buildah task v0.11.0 removed the `sbom-syft-generate` step; SBOM generation now
runs inside the `build` step. A `stepSpecs` override referencing a removed step
fails pipeline validation with:
[User error] invalid StepOverride: No Step named sbom-syft-generate
Drop the stale `sbom-syft-generate` entry from the `build-images` `stepSpecs`.
The `prepare-sboms` and `build` overrides are kept (both steps still exist).
github-actions
Bot
added
the
review-requested
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Repository UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (62)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
💤 Files with no reviewable changes (62)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe change removes Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~12 minutes Merge Risk: ⚪ Minimal · up to The obsolete step overrides were removed without any remaining review findings. 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
Comment |
Contributor
CI status [antigravity]Run: Build Notebooks (push) #34593813370 — 3/3 complete · 3 skipped No workbench image jobs ran; all matrix jobs were skipped. |
Contributor
📋 Review SummaryThis pull request correctly removes the obsolete 🔍 General Feedback
I did not post inline review comments. |
Contributor
CI status [antigravity]Run: Build Notebooks (pr) #34593820556 — 3/3 complete · 1 passed · 2 skipped No workbench image jobs ran; all matrix jobs were skipped. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4569 +/- ##
=======================================
Coverage 49.27% 49.27%
=======================================
Files 51 51
Lines 6583 6583
Branches 1103 1103
=======================================
Hits 3244 3244
Misses 3056 3056
Partials 283 283
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ide-developer
approved these changes
Sep 11, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ide-developer The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the obsolete
sbom-syft-generatestep override from thebuild-imagesstepSpecsin the ODH Konflux PipelineRuns.Buildah task v0.11.0 removed the
sbom-syft-generatestep (SBOM generation now runsinside the
buildstep). AstepSpecsentry referencing a removed step fails pipelinevalidation with:
The
prepare-sbomsandbuildoverrides are retained (both steps still exist).62
.tekton/PipelineRun files changed (8 lines removed each).Related
sbom-syft-generate; SBOM generation moved into the build step.Testing
sbom-syft-generatereferences remain in.tekton/.Summary by CodeRabbit