Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修正了由于结束页id错误导致的文档解析速度计算不准的问题。 #1590

Closed
wants to merge 1 commit into from

Conversation

dium6i
Copy link

@dium6i dium6i commented Jan 21, 2025

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Solve the problem of incorrect calculation of document parsing speed due to wrong end_page_id.
解决因为结束页id错误而导致的文档解析速度计算有误的问题。

Modification

When start_page_id starts from 0, end_page_id should be document length minus 1. Otherwise, the total number of document pages will be increased by 1 when calculating doc_analyze_speed.
当start_page_id从0开始时,end_page_id应该为文档长度-1。否则会在计算doc_analyze_speed时,导致文档总页数多1页。

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@dium6i dium6i closed this Jan 21, 2025
@myhloli
Copy link
Collaborator

myhloli commented Jan 21, 2025

感谢提交,这个问题之前已经在dev分支修复过了,最近会合并至master

f209dde

@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants