Skip to content

Fix broken device links in SVG network map report#1654

Open
lacatoire wants to merge 1 commit intoopendcim:masterfrom
lacatoire:fix/1568-network-map-svg-link-slash
Open

Fix broken device links in SVG network map report#1654
lacatoire wants to merge 1 commit intoopendcim:masterfrom
lacatoire:fix/1568-network-map-svg-link-slash

Conversation

@lacatoire
Copy link
Copy Markdown

@lacatoire lacatoire commented Feb 10, 2026

Summary

  • Normalized InstallURL with a trailing slash when building device URLs in the SVG network map
  • When InstallURL was configured without a trailing slash (e.g. https://example.com), generated links were malformed: https://example.comdevices.php?DeviceID=123 instead of https://example.com/devices.php?DeviceID=123
  • Uses rtrim($url, '/') . '/' to handle both cases safely

Fixes #1568

When InstallURL was configured without a trailing slash, the generated
SVG links would be malformed (e.g. https://example.comdevices.php
instead of https://example.com/devices.php). Normalize the base URI
to always include a trailing slash.

Fixes opendcim#1568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report_network_map.php -> SVG error link port with slashe

1 participant