Fix Update button not creating pending new device statuses#1661
Open
lacatoire wants to merge 1 commit intoopendcim:masterfrom
Open
Fix Update button not creating pending new device statuses#1661lacatoire wants to merge 1 commit intoopendcim:masterfrom
lacatoire wants to merge 1 commit intoopendcim:masterfrom
Conversation
When a user types a new status name in the blank field and clicks the Update button instead of pressing Enter or clicking the + icon, the new status was silently lost. Now the Update button triggers the add-status action before collecting the form data. Fixes opendcim#1041
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a user types a new device status name in the blank input field on the Configuration page and clicks the Update button (instead of pressing Enter or clicking the + icon), the new status was silently lost.
This fix triggers the add-status action on the pending input before collecting the form data for the Update submission, ensuring no typed status is lost.
Fixes #1041