Fix Privacy Bugs in Odometer and Covariance#624
Merged
joshua-oss merged 3 commits intomainfrom Feb 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes two privacy-accounting bugs affecting reported ε/δ consumption and covariance sensitivity bounds, aligning implementation with intended DP guarantees.
Changes:
- Correct homogeneous odometer “optimal_b” formula by adding the missing
log(1/tol)term (Issue #621). - Fix DP covariance release to compute covariance from clipped/cleaned data rather than the raw input (Issue #622).
- Add a unit test to ensure
DPcovariance.release()uses clipped data; add a sklearn import fallback forLinearModel.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
sql/snsql/sql/odometer.py |
Fixes the homogeneous composition bound by applying the missing log factor in optimal_b. |
sql/tests/odometer/test_odometer.py |
Updates the expected ε value to match the corrected odometer formula. |
synth/snsynth/models/dp_covariance.py |
Ensures covariance is computed from new_data (clipped + imputed) to preserve bounded sensitivity. |
synth/tests/test_dp_covariance.py |
Adds regression test validating release() uses clipped data (noise forced to zero). |
synth/snsynth/models/linear_regression.py |
Adds compatibility import path for LinearModel across sklearn versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was
linked to
issues
Feb 10, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes:
#621 could result in reporting the wrong privacy consumption, and #622 could result in privacy leak