chore: upgrade jQuery UI to version 1.14.1

[luisfelipec95]

Why this change?

This PR updates the local jQuery UI file (openassessment/xblock/static/js/lib/jquery-ui-1.10.4.min.js) from version 1.10.0 (2013) to version 1.14.1(openassessment/xblock/static/js/lib/jquery-ui-1.14.1.min.js) (2024), the latest stable release from the official jQuery UI project.

Motivation

• Security & Maintainability: The previous version (1.10.4) is over a decade old and no longer receives fixes. Upgrading helps reduce technical debt and aligns with modern web standards.
• Modern browser support: jQuery UI 1.14.1 improves compatibility with modern browsers and drops legacy Internet Explorer-specific code.
• Better behavior and fixes: Many UI components (e.g., Dialog, Tabs, Resizable) received bug fixes and accessibility improvements in versions 1.10–1.14.

For full changelog:
https://jqueryui.com/changelog/
https://jqueryui.com/upgrade-guide/1.14/

---

[openedx-webhooks]

Thanks for the pull request, @luisfelipec95!

This repository is currently maintained by @openedx/2u-aurora.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.29%. Comparing base (8b320d6) to head (edd764a).
⚠️ Report is 74 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2314      +/-   ##
==========================================
+ Coverage   95.09%   95.29%   +0.19%     
==========================================
  Files         195      195              
  Lines       21479    21664     +185     
  Branches     1931     1509     -422     
==========================================
+ Hits        20425    20644     +219     
+ Misses        787      771      -16     
+ Partials      267      249      -18     

Flag	Coverage Δ
unittests	95.29% <ø> (+0.19%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[luisfelipec95]

The failure in the workflow is related to the minified jQuery UI file (jquery-ui-1.14.1.min.js), which appears to contain tokens with strange or empty characters. This is causing make check_translations_up_to_date to fail during the extraction phase.

As you can see, the extracted strings are likely artifacts of parsing the minified file, which shouldn't normally be included in the translation workflow.

I also tried running the commands from the Makefile manually to update the translations, but it still fails because of this.

Does anyone know what’s the expected process in this case?

Any guidance would be appreciated. Thanks!

@openedx/content-aurora

[itsjeyd]

@luisfelipec95 Thank you for your contribution! I'm marking it as ready for review by the @openedx/2u-aurora team now.

@openedx/2u-aurora As a first step could you please have a look at @luisfelipec95's questions above?

@feanil It looks like the legacy @openedx-aurora team still exists which might be a source of confusion (OP pinged that team instead of @openedx/2u-aurora in their comment above). Is it still needed or would it make sense to remove it at this point?

[feanil]

We should drop the old openedx-aurora team, I'll take care of that now.

[itsjeyd]

We should drop the old openedx-aurora team, I'll take care of that now.

@feanil Thanks!

--

@openedx/2u-aurora Friendly reminder about this -- could you please let @luisfelipec95 know when you'd be able to reply to the questions they raised earlier?

[itsjeyd]

Hi @openedx/committers-edx-ora2! This PR needs some technical input (see #2314 (comment)), could you please have a look?

[itsjeyd]

@openedx/committers-edx-ora2 A friendly reminder to help out @luisfelipec95 with his questions.

[itsjeyd]

@luisfelipec95 Sorry for the delay here. I reached out on Slack to find a reviewer from the wider CC community.

[itsjeyd]

Hey @openedx/axim-engineering team, could you please have a look at this PR and help @luisfelipec95 with his questions?

It's been a while since this PR was created and so far, my attempts at getting responses from maintainers and/or CCs have been unsuccessful.

[brian-smith-tcril]

My first thought was that we had a specific exclude in place for jquery-ui-1.10.4.min.js somewhere that jquery-ui-1.14.1.min.js wasn't matching. It turns out this is not the case.

When investigating this locally I found out we were getting away with not ignoring vendored minified js.

---

To figure out what was going on I updated

edx-ora2/Makefile

Line 97 in 801fbd1

cd ./openassessment && django-admin makemessages -l en -v1 -d djangojs

to use -v3 instead of -v1 to see all the files being processed on latest master, and found

processing file jquery-ui-1.10.4.min.js in ./xblock/static/js/lib

in the output.

---

I pulled down this PR branch and rebased it on latest master locally (I encountered errors running make install when using this branch directly)

ERROR: Could not find a version that satisfies the requirement lxml==5.2.1 (from versions: 5.3.0, 5.3.1, 5.3.2, 5.4.0, 6.0.0, 6.0.1, 6.0.2)
ERROR: No matching distribution found for lxml==5.2.1

---

I updated the Makefile to ignore the minified jquery-ui file

diff --git a/Makefile b/Makefile
index 6be23a42a..20cd58830 100644
--- a/Makefile
+++ b/Makefile
@@ -94,7 +94,7 @@ static: ## Webpack JavaScript and SASS source files
 
 extract_translations: ## creates the django-partial.po & django-partial.mo files
        cd ./openassessment && django-admin makemessages -l en -v1 -d django
-       cd ./openassessment && django-admin makemessages -l en -v1 -d djangojs
+       cd ./openassessment && django-admin makemessages -l en -v1 -d djangojs -i "*jquery-ui*.min.js"
 
 compile_translations: ## compiles the *.po & *.mo files
        cd ./openassessment/ && i18n_tool generate -v && cd ..

and then I was able to successfully run check_translations_up_to_date.

---

I specifically chose to limit what was being ignored to only the jquery-ui file to avoid any possible unintended consequences of ignoring more vendored files.

That being said, I think it probably makes sense for makemessages to ignore more than just that. I'd prefer to keep PR concerns separate, so I think we should either either:

• Make a new PR updating extract_translations to ignore everything we want to ignore. Land that first, then rebase this PR and land it.

OR

• Add the *jquery-ui*.min.js ignore to this PR to minimize side-effects and land it. Create a follow-up issue to figure out all of the things we want to ignore.

[itsjeyd]

Thanks a lot @brian-smith-tcril!

@luisfelipec95 Does that give you what you need to move forward here? ⬆️