feat: bulk remind for lcr #854
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-hassan-dev
force-pushed
the
ahmad-hassan-dev/ENT-10857
branch
from
b6570d7 to
3cdb5a9
Compare
| ``` | ||
| """ | ||
| # A request is only remindable if it is in the 'APPROVED' state. | ||
| base_queryset = self.get_queryset().filter( |
Member
There was a problem hiding this comment.
does get_queryset() return only the requests belonging to a specific budget?
Comment on lines
404
to
411
| LearnerCreditRequestActions.create_action( | ||
| learner_credit_request=assignment.credit_request, | ||
| recent_action=get_action_choice(LearnerCreditAdditionalActionStates.REMINDED), | ||
| status=get_user_message_choice(LearnerCreditAdditionalActionStates.REMINDED), | ||
| ) | ||
| logger.info( | ||
| f'Created REMINDED action for LearnerCreditRequest {assignment.credit_request.uuid}' | ||
| ) |
Member
There was a problem hiding this comment.
are we logging an action in case of failure with correct state?
ahmad-hassan-dev
force-pushed
the
ahmad-hassan-dev/ENT-10857
branch
2 times, most recently
from
f0450cb to
60eb906
Compare
ahmad-hassan-dev
force-pushed
the
ahmad-hassan-dev/ENT-10857
branch
4 times, most recently
from
7bc17d6 to
d64ee69
Compare
sameenfatima78
approved these changes
Oct 20, 2025
| logger.info(f'Queueing reminders for {len(remindable_requests)} learner credit requests.') | ||
|
|
||
| for req in remindable_requests: | ||
| send_reminder_email_for_pending_learner_credit_request.delay(req.assignment.uuid) |
Member
There was a problem hiding this comment.
this statement seems like it's not indented correctly, kindly check
ahmad-hassan-dev
force-pushed
the
ahmad-hassan-dev/ENT-10857
branch
from
d64ee69 to
dea2c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a description of your changes here.
Jira:
ENT-XXXX
Merge checklist:
./manage.py makemigrationshas been runPost merge: