fix: clean up to get passing test #1550
Conversation
| })), | ||
| }, | ||
| ]; | ||
| if (!isOpen) { |
There was a problem hiding this comment.
[inform] It's OK to render the ProductTour component itself because each tour itself has the enabled: boolean flag, which is also set to isOpen. Then, CheckpointOverlay appears to return null as well if there's no rect, so rendering both CheckpointOverlay and ProductTour here irrespective of isOpen should be a no-op.
| return ( | ||
| <> | ||
| <CheckpointOverlay target={`#${targetSelector}`} /> | ||
| <CheckpointOverlay target={targetSelector} /> |
There was a problem hiding this comment.
[inform] Ensuring we always include # when defining selectors, since the selector is intended to semantically include the #.
| jest.mock('@edx/frontend-platform/i18n', () => ({ | ||
| FormattedMessage: ({ defaultMessage }) => defaultMessage, | ||
| defineMessages: (messages) => messages, | ||
| })); |
There was a problem hiding this comment.
[inform] Unnecessary to mock.
|
|
||
| const mockOnAdvance = jest.fn(); | ||
|
|
||
| const targets = ['#step-1', '#step-2', '#step-3', '#step-4']; |
There was a problem hiding this comment.
[inform] the list of targets is never iterated over, and so we can simply use the explicit selectors where needed without needing to do any transforming to replace the #.
2 participants
For all changes
Only if submitting a visual change