Skip to content

Conversation

zwidekalanga
Copy link
Contributor

@zwidekalanga zwidekalanga commented Jul 22, 2025

  • Change status checks from 'waiting_for_learner' to 'reminded'
  • Change error reason checks from 'Failed: Cancellation' to 'failed_cancellation'
  • Remove status transformation in useBnrSubsidyRequests hook
  • Add formatErrorReason function in BnrRequestStatusCell for display formatting
  • Update status display mapping in BudgetDetailApprovedRequestTable
  • Update modal text from 'assigned' to 'pending'
  • Update test data to use new status format

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Screenshot

Screenshot 2025-07-22 at 11 49 16 AM

…lues

- Change status checks from 'waiting_for_learner' to 'reminded'
- Change error reason checks from 'Failed: Cancellation' to 'failed_cancellation'
- Remove status transformation in useBnrSubsidyRequests hook
- Add formatErrorReason function in BnrRequestStatusCell for display formatting
- Update status display mapping in BudgetDetailApprovedRequestTable
- Update modal text from 'assigned' to 'pending'
- Update test data to use new status format
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (da6362f) to head (063e3c1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1600      +/-   ##
==========================================
- Coverage   86.83%   86.83%   -0.01%     
==========================================
  Files         778      778              
  Lines       17597    17596       -1     
  Branches     3682     3593      -89     
==========================================
- Hits        15280    15279       -1     
- Misses       2242     2251       +9     
+ Partials       75       66       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@omar-sarfraz
Copy link
Member

Just wondering if we also need to update this constant. We're using it to determine whether the last action was reminded. If the recent backend changes now return recentAction with a lowercase key, we may need to update this constant accordingly.

We're currently using this constant here.

const errorReasonMap = {
failed_approval: 'Failed: Approval',
failed_cancellation: 'Failed: Cancellation',
failed_system: 'Failed: System Error',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think, there isn't any state for failed_system, failed_payment and failed_enrollment

Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just mentioninig, do we need to make any changes RequestFailureModal.jsx as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants