-
Notifications
You must be signed in to change notification settings - Fork 37
feat: update action status handling to use keys instead of display value #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: update action status handling to use keys instead of display value #1600
Conversation
…lues - Change status checks from 'waiting_for_learner' to 'reminded' - Change error reason checks from 'Failed: Cancellation' to 'failed_cancellation' - Remove status transformation in useBnrSubsidyRequests hook - Add formatErrorReason function in BnrRequestStatusCell for display formatting - Update status display mapping in BudgetDetailApprovedRequestTable - Update modal text from 'assigned' to 'pending' - Update test data to use new status format
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1600 +/- ##
==========================================
- Coverage 86.83% 86.83% -0.01%
==========================================
Files 778 778
Lines 17597 17596 -1
Branches 3682 3593 -89
==========================================
- Hits 15280 15279 -1
- Misses 2242 2251 +9
+ Partials 75 66 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
const errorReasonMap = { | ||
failed_approval: 'Failed: Approval', | ||
failed_cancellation: 'Failed: Cancellation', | ||
failed_system: 'Failed: System Error', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think, there isn't any state for failed_system, failed_payment and failed_enrollment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just mentioninig, do we need to make any changes RequestFailureModal.jsx as well?
For all changes
Only if submitting a visual change
Screenshot