-
Notifications
You must be signed in to change notification settings - Fork 245
feat: support design tokens and paragon 23 #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
c51133f
to
80ea053
Compare
Nice, thanks! Let me know when this is ready for review. |
80ea053
to
77b9712
Compare
bc40e90
to
66f4505
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1588 +/- ##
==========================================
- Coverage 90.18% 90.18% -0.01%
==========================================
Files 338 338
Lines 5726 5725 -1
Branches 1382 1381 -1
==========================================
- Hits 5164 5163 -1
- Misses 543 545 +2
+ Partials 19 17 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
96499bf
to
490dcdf
Compare
Sandbox deployment failed 💥 |
490dcdf
to
631f420
Compare
Sandbox deployment failed 💥 |
Warning
This PR should not be merge to
master
directly, it should point tomaster-design-tokens
once the branch has been created.Description
This PR updates frontend app learning to support CSS variables and the corresponding paragon design tokens.
Changes implemented
Important
This PR requires a compatible version with paragon 23 of dependencies because of that the following PRs need to be merged first: