fix: sidebar unitid undefined

[wgu-jesse-stewart]

Fixes #1747

This bug is due to activeUnitId being null when viewing a locked unit. The fix was to add some defensiveness to the handleUnitClick and checkBlockCompletion functions.

This prevents sendTrackEvent, sendTrackingLogEvent, checkBlockCompletion from running when navigating from a locked unit. If those methods need to run, even when the unit is locked, then we need to add some more logic to handle that state without throwing a null pointer error.

459990789-b3f44230-e957-4c8f-b608-15b185d5e4d0.mp4

[openedx-webhooks]

Thanks for the pull request, @wgu-jesse-stewart!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[Copilot]

Pull Request Overview

This PR fixes a bug where activeUnitId is null when viewing a locked unit, causing null pointer errors in tracking events and completion checks. The fix adds defensive programming to prevent these errors when navigating from locked units.

• Adds null checks in checkBlockCompletion function to handle undefined unitId
• Updates handleUnitClick to safely handle null activeUnitId in sequence lookups and completion checks
• Prevents tracking events and completion checks from running when unit data is unavailable

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/courseware/data/thunks.js	Adds early return in checkBlockCompletion when unitId is null/undefined
src/courseware/course/sidebar/sidebars/course-outline/hooks.js	Adds defensive checks in handleUnitClick for null unit IDs and sequences

Comments suppressed due to low confidence (1)

src/courseware/course/sidebar/sidebars/course-outline/hooks.js:77

• [nitpick] The parameter name 'searchUnitId' is inconsistent with the original 'activeUnitId' usage. Consider using 'unitId' for consistency.

      const findSequenceByUnitId = (searchUnitId) => {

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (b050535) to head (5806489).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
+ Coverage   90.46%   90.49%   +0.03%     
==========================================
  Files         344      344              
  Lines        5812     5820       +8     
  Branches     1360     1405      +45     
==========================================
+ Hits         5258     5267       +9     
+ Misses        537      536       -1     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[open-craft-grove]

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[open-craft-grove]

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements