Node 16 upgrade and peer dependency cleanup

.github/workflows/bump-all-major.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Setup Nodejs
         uses: actions/setup-node@v1
         with:
-          node-version: 12
+          node-version: 16
       # lerna expects to be authenticated for publishing to NPM. This step will fail CI if NPM is not authenticated
       - name: Check NPM authentication
         run: |
@@ -35,7 +35,7 @@ jobs:
         run: npm run test
       - name: Coverage Report
         uses: codecov/codecov-action@v1
-      - name: 
+      - name: Force publish major versions
         run: lerna version major --force-publish --yes
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/ci.yml

@@ -1,46 +1,42 @@
 name: CI
 
-on: [push]
+on: [pull_request]
 
 jobs:
-  build:
+  tests:
     name: Build
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-        with:
-          # pulls all commits (needed for lerna / semantic release to correctly version)
-          fetch-depth: 0
-      # pulls all tags (needed for lerna / semantic release to correctly version)
-      - run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
-      - name: Setup Nodejs
-        uses: actions/setup-node@v1
-        with:
-          node-version: 12
-      # lerna expects to be authenticated for publishing to NPM. This step will fail CI if NPM is not
-      # authenticated, even though this build does _not_ attempt to publish, as an extra check before merge
-      # that Lerna is set to publish.
-      - name: Check NPM authentication
-        run: |
-          echo "//registry.npmjs.org/:_authToken=${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }}" >> .npmrc
-          npm whoami
-      - name: Install and Setup Dependencies
-        run: |
-          npm install
-          lerna bootstrap --include-dependencies --include-dependents --since origin/master
-      # build must come before running linting and tests for the `dist` directory to exist.
-      - name: Build
-        run: lerna run build --include-dependencies --include-dependents --since origin/master --parallel
-      - name: Lint
-        run: lerna run lint --include-dependencies --include-dependents --since origin/master --parallel
-      - name: Test
-        run: lerna run test --include-dependencies --include-dependents --since origin/master --parallel
-      - name: Coverage Report
-        uses: codecov/codecov-action@v1
-      - name: Extract branch name
-        shell: bash
-        run: echo "##[set-output name=branch;]$(echo ${GITHUB_REF#refs/heads/})"
-        id: extract_branch
-      - name: Preview Updated Versions (dry run)
-        run: lerna version --allow-branch ${{ steps.extract_branch.outputs.branch }} --no-git-tag-version --no-changelog --no-push --yes
+    - name: Checkout
+      uses: actions/checkout@v2
+      with:
+        # pulls all commits (needed for lerna / semantic release to correctly version)
+        fetch-depth: 0
+    # pulls all tags (needed for lerna / semantic release to correctly version)
+    - run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
+    - name: Setup Nodejs
+      uses: actions/setup-node@v3
+      with:
+        node-version: 16
+    # lerna expects to be authenticated for publishing to NPM. This step will fail CI if NPM is not
+    # authenticated, even though this build does _not_ attempt to publish, as an extra check before merge
+    # that Lerna is set to publish.
+    - name: Check NPM authentication
+      run: |
+        echo "//registry.npmjs.org/:_authToken=${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }}" >> .npmrc
+        npm whoami
+    - name: Install and Setup Dependencies
+      run: npm run setup
+    # build must come before running linting and tests for the `dist` directory to exist.
+    - name: Build
+      run: lerna run build
+    - name: Lint
+      run: lerna run lint
+    - name: Test
+      run: lerna run test
+    - name: Coverage Report
+      uses: codecov/codecov-action@v2
+    - name: Preview Updated Versions (dry run)
+      run: |
+        git switch -c "actual-branch-not-detached-head"
+        lerna version --allow-branch actual-branch-not-detached-head --no-git-tag-version --no-changelog --no-push --yes

.github/workflows/publish-from-package.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Setup Nodejs
         uses: actions/setup-node@v1
         with:
-          node-version: 12
+          node-version: 16
       # lerna expects to be authenticated for publishing to NPM. This step will fail CI if NPM is not authenticated
       - name: Check NPM authentication
         run: |

.github/workflows/release.yml

@@ -21,7 +21,7 @@ jobs:
       - name: Setup Nodejs
         uses: actions/setup-node@v1
         with:
-          node-version: 12
+          node-version: 16
       # lerna expects to be authenticated for publishing to NPM. This step will fail CI if NPM is not authenticated
       - name: Check NPM authentication
         run: |

.nvmrc

@@ -1 +1 @@
-12
+16

common/extendESLintConfig.js

@@ -0,0 +1,21 @@
+const path = require('path');
+
+const extendESLintConfig = (config) => {
+  const importNoUnresolved = config.rules['import/no-unresolved'];
+  if (importNoUnresolved ) {
+    const originalIgnore = importNoUnresolved[1].ignore;
+    if (!originalIgnore.includes('@edx/frontend-enterprise-*')) {
+      importNoUnresolved[1].ignore = [...originalIgnore, '@edx/frontend-enterprise-*'];
+    }
+  }
+  config.settings = {
+    ...config.settings,
+    'import/resolver': {
+      alias: [
+        ['@edx/frontend-enterprise-utils', '../utils/src'],
+      ],
+    },
+  };
+};
+
+module.exports =  extendESLintConfig;

common/extendJestConfig.js

@@ -0,0 +1,10 @@
+const extendJestConfig = (config) => {
+  const modulePathsToIgnore = ['<rootDir>/dist'];
+  config.modulePathIgnorePatterns = config.modulePathIgnorePatterns ? [...config.modulePathIgnorePatterns, ...modulePathsToIgnore] : modulePathsToIgnore;
+  config.moduleNameMapper = {
+    ...config.moduleNameMapper,
+    '@edx/frontend-enterprise-(.*)': '<rootDir>/../$1/src',
+  };
+};
+
+module.exports =  extendJestConfig;