Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update GitHub actions step output to correctly set generated_pr #589

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jan 23, 2025

Tracking Issue: edx/edx-arch-experiments#855

Description:

This PR fixes an issue caused by replacing deprecated github action ::set-output command with a print statement referencing $GITHUB_OUTPUT (reference: #533) which did not actually set the step output for github actions, leading to OpsGenie alert failures.
The fix removes the print statement and writes the generated PR URL directly to the file given by GITHUB_OUTPUT. Affected tests have also been updated to mock file writes rather than expecting a print call.

@BilalQamar95 BilalQamar95 self-assigned this Jan 23, 2025
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/github-actions-output-fix branch from f4e2484 to 4fbca3f Compare January 23, 2025 13:02
@BilalQamar95 BilalQamar95 marked this pull request as draft January 24, 2025 10:12
@BilalQamar95 BilalQamar95 marked this pull request as ready for review January 24, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant