fix: Replace migrate hooks with longer timeouts and retries#136
Open
tamalsaha wants to merge 1 commit intoopenfga:mainfrom
Open
fix: Replace migrate hooks with longer timeouts and retries#136tamalsaha wants to merge 1 commit intoopenfga:mainfrom
tamalsaha wants to merge 1 commit intoopenfga:mainfrom
Conversation
5408b1c to
9e7b50d
Compare
95d47a1 to
a570549
Compare
ad7be30 to
ded76bc
Compare
xref: https://x.com/tsaha/status/1805382111844778275 Signed-off-by: Tamal Saha <[email protected]>
Contributor
Author
|
Tested in ArgoCD using apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
name: openfga
namespace: argocd
spec:
project: default
source:
chart: openfga
repoURL: ghcr.io/appscode-charts
targetRevision: 0.2.13
helm:
releaseName: openfga
valuesObject:
datastore:
engine: postgres
uri: "postgres://postgres:[email protected]:5432/postgres?sslmode=disable"
postgresql:
enabled: true
auth:
postgresPassword: password
database: postgres
destination:
server: "https://kubernetes.default.svc"
namespace: default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to use this chart with fluxcd
Description
Helm charts and Jobs don't work well together. This is evident from many prs trying to address some aspects of this issue. I try to document the issues as best I can think of here: https://x.com/tsaha/status/1805382111844778275
This pr tries to address this issue as best as possible I think.
If the hooks are used, we can't use fluxcd to install this chart with --wait flag. See here: fluxcd/flux2#1085 (comment)
What seems to work well in our experience is just run the migrate job at the same time as the potential db sub-chart, increase the timeout of the migrate job and increase number of retries. #130 pr ensures that at least one successful run of the migrate job will be considered successful. So, extending the timeout and increasing retries works well even if the db subchart takes unusally long time to be ready.
References
Review Checklist
main