feat: Support initContainers in migration job#202
Merged
jeremy-albuixech merged 2 commits intoopenfga:mainfrom Mar 31, 2025
Merged
feat: Support initContainers in migration job#202jeremy-albuixech merged 2 commits intoopenfga:mainfrom
jeremy-albuixech merged 2 commits intoopenfga:mainfrom
Conversation
vihangm
force-pushed
the
vihang/support_init_migrate
branch
from
fd12a81 to
689871c
Compare
Signed-off-by: Vihang Mehta <vihang@gimletlabs.ai>
vihangm
force-pushed
the
vihang/support_init_migrate
branch
from
689871c to
3c2d55b
Compare
jeremy-albuixech
approved these changes
Mar 31, 2025
Contributor
jeremy-albuixech
left a comment
jeremy-albuixech
left a comment
There was a problem hiding this comment.
looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using Google Cloud SQL as a database provider, the database is made available via a sidecar that proxies the requests. To ensure that migrations work in such scenarios, initContainers need to be supported in the migration job.
I tried to use the initContainer (non-job) style migration, but that doesn't work either since the initContainers are run in order and the migration initContainer is added before
extraInitContainersin the deployment. So the proxy doesn't run until after the migration init is expected to complete.References
Fixes #191
Review Checklist
main