bug: Allow disabling the http service and metrics with helm#204
Merged
jeremy-albuixech merged 1 commit intoopenfga:mainfrom Mar 26, 2025
Merged
bug: Allow disabling the http service and metrics with helm#204jeremy-albuixech merged 1 commit intoopenfga:mainfrom
jeremy-albuixech merged 1 commit intoopenfga:mainfrom
Conversation
Signed-off-by: Vihang Mehta <[email protected]>
jeremy-albuixech
approved these changes
Mar 26, 2025
Contributor
jeremy-albuixech
left a comment
There was a problem hiding this comment.
that makes sense, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gating the
OPENFGA_HTTP_ENABLEDandOPENFGA_METRICS_ENABLEDblocks means that when the value is set to false, the env vars are not set. This causes the deployment to use the default values for these configs which isEnabled: true. Instead we should do the same thing as we do in theOPENFGA_PLAYGROUND_ENABLEDenv var and always set it so that these can be disabled by helm users.References
N/A
Review Checklist
main