Skip to content

bug: Allow disabling the http service and metrics with helm#204

Merged
jeremy-albuixech merged 1 commit intoopenfga:mainfrom
vihangm:vihang/http_en
Mar 26, 2025
Merged

bug: Allow disabling the http service and metrics with helm#204
jeremy-albuixech merged 1 commit intoopenfga:mainfrom
vihangm:vihang/http_en

Conversation

@vihangm
Copy link
Contributor

@vihangm vihangm commented Mar 26, 2025

Description

Gating the OPENFGA_HTTP_ENABLED and OPENFGA_METRICS_ENABLED blocks means that when the value is set to false, the env vars are not set. This causes the deployment to use the default values for these configs which is Enabled: true. Instead we should do the same thing as we do in the OPENFGA_PLAYGROUND_ENABLED env var and always set it so that these can be disabled by helm users.

References

N/A

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@vihangm vihangm requested review from a team as code owners March 26, 2025 00:15
Copy link
Contributor

@jeremy-albuixech jeremy-albuixech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense, thanks for the contribution!

@jeremy-albuixech jeremy-albuixech merged commit bab7cc4 into openfga:main Mar 26, 2025
4 checks passed
@vihangm vihangm deleted the vihang/http_en branch March 26, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments