fix(otel): OPENFGA_TRACE_OTLP_TLS_ENABLED boolean flag quote#280
fix(otel): OPENFGA_TRACE_OTLP_TLS_ENABLED boolean flag quote#280yannchabed wants to merge 1 commit intoopenfga:mainfrom
Conversation
WalkthroughThe OpenFGA Helm chart deployment template was updated to change the OPENFGA_TRACE_OTLP_TLS_ENABLED environment variable from an unquoted YAML value to a quoted string literal, ensuring proper YAML formatting. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
cc @rhamzeh as a regular contributor WDYT? |
This PR ensures that the
OPENFGA_TRACE_OTLP_TLS_ENABLEDenvironment variable is correctly handled as a boolean string within the Helm chart templates.Description
What problem is being solved?
In the current Helm chart, the
OPENFGA_TRACE_OTLP_TLS_ENABLEDvariable—used to toggle TLS for OpenTelemetry Protocol (OTLP) tracing—was not being correctly processed. In Kubernetes manifests, environment variable values must be strings. If a boolean (true/false) is passed directly from Helm'svalues.yamlwithout explicit casting or quoting, it causes template rendering errors or be misinterpreted by the OpenFGA server at runtime.How is it being solved?
The issue is resolved by updating the deployment template to ensure that the value of
OPENFGA_TRACE_OTLP_TLS_ENABLEDis explicitly converted to a string (quoted) before being injected into the container environment. This ensures compatibility with Kubernetes API expectations and OpenFGA's configuration logic.What changes are made to solve it?
templates/deployment.yamlto include theOPENFGA_TRACE_OTLP_TLS_ENABLEDenvironment variable.Applied thesurround the value with double quotes to ensure boolean inputs fromquotefunctionvalues.yamlare rendered as"true"or"false".References
Review Checklist
I have added documentation for new/changed functionality in this PR or in a PR to [openfga.dev](https://github.com/openfga/openfga.dev)mainI have added tests to validate that the change in functionality is working as expectedNo test coverageNext Step: Would you like me to help you draft a specific comment for the maintainers or analyze the related CI/CD failures if there are any?
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.