-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support start_time parameter on read_changes #186
feat: support start_time parameter on read_changes #186
Conversation
Note: This currently includes the read changes start_time variable but does not include Batch Check updates. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
- Coverage 87.70% 87.65% -0.06%
==========================================
Files 23 23
Lines 1139 1142 +3
Branches 196 198 +2
==========================================
+ Hits 999 1001 +2
Misses 83 83
- Partials 57 58 +1 ☔ View full report in Codecov by Sentry. |
4e02e59
to
cda05b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good.
I'd discard the changes in package-lock.json
to fix CI (I always find it awkward to keep this in sync correctly with sdk-generator), and also the eslint
file that looks to have been added.
Description
Adds support for the start_time variable for read changes.
References
openfga/sdk-generator#455
Review Checklist
main