Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct content type for token request #65

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix: use correct content type for token request #65

merged 1 commit into from
Feb 12, 2024

Conversation

ewanharris
Copy link
Member

Description

Moves the client to use application/x-www-form-urlencoded for the content type when making token requests per the spec.

In order to do this we set the header on the request and axios will serialize the data we provide for us

References

Part of openfga/sdk-generator#284
Generated from openfga/sdk-generator#308

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested a review from a team as a code owner February 9, 2024 16:31
@rhamzeh rhamzeh added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit 8741983 Feb 12, 2024
19 checks passed
@rhamzeh rhamzeh deleted the fix/284-token-request-type branch February 12, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewanharris @rhamzeh