-
Notifications
You must be signed in to change notification settings - Fork 21
chore(docs): clean up and fix imports and initialization in README #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems good
This PR Also covers #23, I was not aware that we have different Issue for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @JRudransh!
Can I ask you to:
- Sign the EasyCLA in the comment above (we need it in order to merge)
- amend your commit message to be
chore(docs): clean up and fix imports and initialization in README
and force push?
Marking as "Request Changes" so that we don't merge before EasyCLA is signed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added required changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Changes are based on
openfga-sdk==0.4.0
openfga_sdk
I have imported them and keep them as comments.References
#28
Review Checklist
main