Skip to content

chore(docs): clean up and fix imports and initialization in README #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

JRudransh
Copy link
Contributor

Description

Changes are based on openfga-sdk==0.4.0

  1. Wherever we are using some modules from the openfga_sdk I have imported them and keep them as comments.
  2. I found some syntax errors in existing code, so i fixed them
  3. I have reformatted the code
  4. I have added return statement on main function from there we are doing some query

References

#28

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@JRudransh JRudransh requested a review from a team as a code owner January 16, 2024 11:48
Copy link

linux-foundation-easycla bot commented Jan 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: JRudransh / name: Rudransh Jagannath (a3ceb2a)

Copy link
Contributor Author

@JRudransh JRudransh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good

@JRudransh
Copy link
Contributor Author

This PR Also covers #23, I was not aware that we have different Issue for that

@rhamzeh rhamzeh changed the title add import and client initialization as comments for each code block and fixed some syntax error chore(docs): clean up and fix imports and initialization in README Jan 22, 2024
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @JRudransh!

Can I ask you to:

  • Sign the EasyCLA in the comment above (we need it in order to merge)
  • amend your commit message to be chore(docs): clean up and fix imports and initialization in README and force push?

Marking as "Request Changes" so that we don't merge before EasyCLA is signed

@JRudransh
Copy link
Contributor Author

I have already signed the EasyCLA, I have also got the conformation email
image

Copy link
Contributor Author

@JRudransh JRudransh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added required changes

@JRudransh JRudransh requested a review from rhamzeh January 22, 2024 16:06
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rhamzeh rhamzeh added this pull request to the merge queue Jan 22, 2024
@rhamzeh rhamzeh removed this pull request from the merge queue due to a manual request Jan 22, 2024
@rhamzeh rhamzeh added this pull request to the merge queue Jan 22, 2024
Merged via the queue into openfga:main with commit 7be1c05 Jan 22, 2024
@JRudransh JRudransh deleted the #28 branch January 22, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants