Support API URL configuration in JS and Python SDKs #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanharris
force-pushed
the
feat/298-js-py-api-url
branch
from
f9e7184 to
7b17ca8
Compare
This was referenced Feb 2, 2024
rhamzeh
reviewed
Feb 2, 2024
|
Build issue is fixed by #303 |
rhamzeh
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for configuring the API URL in the JS and Python SDKs instead of configuring a scheme + host. This is attempted in a backwards compatible manner, including making types optional.
Also copies across a change from the Python SDK where changes were made to the formatting of code in the README
References
Closes #298
JS PR: openfga/js-sdk#60
Python PR: openfga/python-sdk#67
Review Checklist
main