Tag jobs with owning instance and reap orphans on boot - #176
Merged
Conversation
A crashed or restarted dyno leaves its in-flight job row stuck at pending/running forever, which blocks that user/survey cluster-wide until the existing 60-minute stale-job reaper eventually catches it. Stamp every inserted job row with the owning process' instanceId (ProcessEnv.instanceId) and add JobRepository.failOrphanedByInstanceId, so a fresh boot of the same dyno can immediately fail any pending/running row still tagged with its own instanceId - no staleness window needed, since a brand-new process couldn't have created that row itself. The time-based reaper remains as the fallback for a dyno that never comes back at all.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A crashed or restarted dyno leaves its in-flight job row stuck at pending/running forever, which blocks that user/survey cluster-wide until the existing 60-minute stale-job reaper eventually catches it.
Stamp every inserted job row with the owning process' instanceId (ProcessEnv.instanceId) and add JobRepository.failOrphanedByInstanceId, so a fresh boot of the same dyno can immediately fail any pending/running row still tagged with its own instanceId - no staleness window needed, since a brand-new process couldn't have created that row itself. The time-based reaper remains as the fallback for a dyno that never comes back at all.