Skip to content

5758 - Navigation: Data errors - Move validateCountry<...> from controller#6145

Merged
mergify[bot] merged 3 commits into
5758-navigation-data-errorsfrom
5758-navigation-data-errors-99
Jul 17, 2026
Merged

5758 - Navigation: Data errors - Move validateCountry<...> from controller#6145
mergify[bot] merged 3 commits into
5758-navigation-data-errorsfrom
5758-navigation-data-errors-99

Conversation

@yaguzmang

@yaguzmang yaguzmang commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Moving validateCountryTables and buildTablesNodeUpdates from the validations controller to src/tools/validations/tables and validateCountryNationalDataPoints to src/tools/validations/nationalDataPoint, since these functions are used only by the validation tools.

Also grouping shared tool files under src/tools/validations/common and removing the redundant validateNationalDataPoint wrapper.

This is how the tools/validations/ folder looks like now:

src/tools/validations/
├── common/
│   ├── failures.ts
│   ├── types.ts
│   └── validateCountries.ts
├── nationalDataPoint/
│   └── validateCountryNationalDataPoints.ts
├── tables/
│   ├── buildTablesNodeUpdates.ts <--- Used only by validateCountryTables.ts
│   └── validateCountryTables.ts
├── validateAll.ts
├── validateDescriptions.ts
├── validateLinks.ts
├── validateNationalDataPoints.ts
└── validateTableData.ts

@yaguzmang
yaguzmang marked this pull request as ready for review July 16, 2026 16:21
@mergify mergify Bot added the queued label Jul 17, 2026
@mergify

mergify Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-07-17 07:40 UTC · Rule: default · triggered by rule Automatic merge using squash
  • Checks skipped · PR is already up-to-date
  • Merged2026-07-17 07:40 UTC · at a837301fc6e39108c45857464e14ad39b6aad29b · squash

This pull request spent 11 seconds in the queue, including 1 second running CI.

Required conditions to merge

@mergify
mergify Bot merged commit 8428200 into 5758-navigation-data-errors Jul 17, 2026
5 checks passed
@mergify
mergify Bot deleted the 5758-navigation-data-errors-99 branch July 17, 2026 07:40
@mergify mergify Bot removed the queued label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants