Skip to content

Commit

Permalink
comment out getPGVersion on json
Browse files Browse the repository at this point in the history
  • Loading branch information
@dimitre
dimitre authored Aug 21, 2024
1 parent ee20d10 commit 540ff9c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions commandLine/src/projects/xcodeProject.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -891,8 +891,8 @@ bool xcodeProject::saveProjectFile(){

contents.close();

json jversion = getPGVersion();
j["_OFProjectGeneratorVersion"] = jversion;
// json jversion = getPGVersion();
// j["_OFProjectGeneratorVersion"] = jversion;


for (auto & c : commands) {
Expand Down

3 comments on commit 540ff9c

@danoli3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so weird this broke it

@dimitre
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think nlohmann/json changed internally to be more strict.
still trying to find why json dump now encloses everything with brackets.
maybe related to this
nlohmann/json#4320

@dimitre
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put back using try / except or maybe using another function to create this key

Please sign in to comment.