Skip to content

Conversation

@TsProphet94
Copy link
Contributor

Description:

Adds a new Bosphorus Map (Turkey). One of the key strategic locations in the world and control access to the Black Sea. Smaller map that most to facilitate smaller FFA and Team games. Added are a selection of nations that correspond to the location.

image

Image 16-01-2026 at 17 39
Image 16-01-2026 at 17 39 (1)

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

TSProphet

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Walkthrough

A new "Bosphorus Straits" map was added: map assets and manifest, registration in the map generator, localization string, enum/type inclusion, and playlist frequency entry.

Changes

Cohort / File(s) Summary
Map data & manifest
map-generator/assets/maps/bosphorusstraits/info.json, resources/maps/bosphorusstraits/manifest.json
New JSON files that define the Bosphorus Straits map, nations with coordinates, flags, and scaled variants (map16x, map4x). Review coordinate correctness and land tile counts.
Map generator registry
map-generator/main.go
Added bosphorusstraits entry to the maps registry. Check naming consistency with resources and manifest.
Localization
resources/lang/en.json
Added "bosphorusstraits": "Bosphorus Straits" under map translations. Verify punctuation/comma consistency.
Game types & classification
src/core/game/Game.ts
Added GameMapType.BosphorusStraits enum member and included it in mapCategories.regional. Ensure enum string matches manifest/name.
Playlist weighting
src/server/MapPlaylist.ts
Replaced a Sierpinski frequency entry with BosphorusStraits: 3 in the map frequency map. Confirm intended weighting and absence of unintended map removal.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A strait of stories, narrow and bright,
Two continents meet beneath the light,
New pins on the atlas, eager and vast,
Bosphorus sails into the cast,
Mapmakers cheer — a new route to write! 🌊🗺️

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a new Bosphorus Straits map. It directly matches the changeset which adds map files, configurations, and enum entries.
Description check ✅ Passed The description explains the purpose and context of the new map, mentions its strategic importance, and notes it facilitates smaller games. It relates to the changeset and confirms completion of required tasks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 16, 2026
@ryanbarlow97 ryanbarlow97 added this to the v30 milestone Jan 20, 2026
@iiamlewis iiamlewis added the Maps A new map, or adjustments to an existing map itself, its json, etc, label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maps A new map, or adjustments to an existing map itself, its json, etc,

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants