-
Notifications
You must be signed in to change notification settings - Fork 797
fix: add validation for unknown flags in manifest.json #3044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,8 +98,7 @@ | |
| }, | ||
| { | ||
| "coordinates": [404, 1146], | ||
| "name": "Fermanagh", | ||
| "flag": "gb-nir" | ||
| "name": "Fermanagh" | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -113,7 +113,6 @@ | |
| }, | ||
| { | ||
| "coordinates": [404, 1146], | ||
| "flag": "gb-nir", | ||
| "name": "Fermanagh" | ||
| } | ||
| ] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import fs from "fs"; | ||
| import { globSync } from "glob"; | ||
| import path from "path"; | ||
|
|
||
| type Nation = { | ||
| flag?: string; | ||
| }; | ||
|
|
||
| type Manifest = { | ||
| nations?: Nation[]; | ||
| }; | ||
|
|
||
| describe("Map manifests: nation flags exist", () => { | ||
| test("All nations' flags reference existing SVG files", () => { | ||
| const manifestPaths = globSync("resources/maps/**/manifest.json"); | ||
|
|
||
| expect(manifestPaths.length).toBeGreaterThan(0); | ||
|
|
||
| const flagDir = path.join(__dirname, "../resources/flags"); | ||
| const errors: string[] = []; | ||
|
|
||
| for (const manifestPath of manifestPaths) { | ||
| try { | ||
| const raw = fs.readFileSync(manifestPath, "utf8"); | ||
| const manifest = JSON.parse(raw) as Manifest; | ||
|
|
||
| (manifest.nations ?? []).forEach((nation, idx) => { | ||
| const flag = nation?.flag; | ||
| if (flag === undefined || flag === null) return; | ||
| if (typeof flag !== "string") { | ||
| errors.push( | ||
| `${manifestPath} -> nations[${idx}].flag is not a string`, | ||
| ); | ||
| return; | ||
| } | ||
|
|
||
| if (flag.trim().length === 0) return; | ||
| if (flag.startsWith("!")) return; | ||
|
|
||
| const svgFile = flag.endsWith(".svg") ? flag : `${flag}.svg`; | ||
| const flagPath = path.join(flagDir, svgFile); | ||
| if (!fs.existsSync(flagPath)) { | ||
| errors.push( | ||
| `${manifestPath} -> nations[${idx}].flag "${flag}" does not exist in resources/flags`, | ||
| ); | ||
| } | ||
| }); | ||
| } catch (err) { | ||
| errors.push( | ||
| `Failed to parse ${manifestPath}: ${(err as Error).message}`, | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| if (errors.length > 0) { | ||
| throw new Error( | ||
| "Map manifest flag file violations:\n" + errors.join("\n"), | ||
| ); | ||
| } | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.