-
Notifications
You must be signed in to change notification settings - Fork 793
Add new map “The Box” #3054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add new map “The Box” #3054
Conversation
The info.json and image.png files needed to generate the map
All the files needed to run and play the new map "The Box" correctly
Updated to add "The Box" to the list so that the necessary files for this map can be generated
Updated to add the new map "The Box" as a playable map and in the 'Arcade' category
Added map name "The Box"
Added Spanish translation of the map "The Box" > "La Caja"
The map "The Box" has been added to the public match list with a frequency set to '3'
WalkthroughA new game map called "TheBox" is added to the system across multiple layers: map data files with nation positions, configuration entries registering the map in the game registry and playlist, and localization strings in English and Spanish. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
🤖 Fix all issues with AI agents
In `@map-generator/assets/maps/thebox/info.json`:
- Around line 1-17: The JSON file "info.json" is not formatted according to
project Prettier rules; run the repository formatter (e.g., Prettier) or
reformat the file so the top-level "name" and "nations" array are properly
indented and spaced, ensure consistent quoting/commas, add a final newline, and
save the formatted result to clear the CI Prettier warning.
In `@resources/lang/es.json`:
- Around line 145-146: Revert the changes to the non‑English locale file
resources/lang/es.json by removing the added/modified keys ("halkidiki",
"thebox") so es.json remains unchanged in this PR, and instead ensure the
corresponding key additions/updates are present only in resources/lang/en.json;
leave translation updates for non‑English locales to the dedicated translation
PR flow (the "mls" PRs by Aotumori).
- Around line 145-146: The JSON is invalid because the "halkidiki" entry is
missing a trailing comma before the "thebox" entry; update the
resources/lang/es.json object by adding a comma after the "halkidiki":
"Halkidiki" line so the "thebox": "La Caja" entry is properly separated,
ensuring the file parses as valid JSON.
In `@resources/maps/thebox/manifest.json`:
- Around line 1-124: Run the code formatter (Prettier) on manifest.json to fix
styling CI errors: reformat the JSON so keys/values in the root object ("map",
"map16x", "map4x", "name", "nations") and the arrays of nation objects are
properly spaced/indented, ensure consistent use of double quotes, remove any
trailing commas, and add a final newline; commit the reformatted manifest.json
so CI no longer reports the Prettier warning.
In `@src/core/game/Game.ts`:
- Line 114: The enum member TheBox has spacing that triggers Prettier; update
the enum declaration (specifically the TheBox member in Game enum) to follow
project formatting by adding spaces around the equals sign and ensuring
consistent spacing (e.g., change TheBox= "The Box", to use TheBox = "The Box",)
so the file passes Prettier/CI.
sardidefcon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated according to the design parameters established by the community
sardidefcon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated according to the design parameters established by the community so that it can be translated from the official translation platform into other languages
sardidefcon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to the parameters required by automatic moderation
The Spanish translation has been removed at the request of the community so that it can be edited from the translation platform.
Description:
This proposal adds a new, completely flat map called "The Box," where players will find themselves on a completely flat landmass and will only be able to trade by land using trains and factories.
All other bots are distributed to cover the map evenly.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
sardidefcon