Skip to content

Conversation

@sardidefcon
Copy link

banner

Description:

This proposal adds a new, completely flat map called "The Box," where players will find themselves on a completely flat landmass and will only be able to trade by land using trains and factories.

  • Map size: 2048×2048 pixels
  • Binaries generated with MapGenerator (map.bin, map4x.bin, map16x.bin)
  • Integrated into arcade category and multiplayer playlist
  • English and Spanish translations added
  • 13 nations/bots with unique and thematic names:
  • Middle Defender (located in the center)
  • King of the Corner (located in the top-left corner)
  • Suspicious Ally
  • Punch Merchant
  • Nuke Thrower
  • Fullsender
  • Factory Builder
  • Front Manager
  • Box Fighter
  • Cage Liberator
  • Train Trader
  • Non-peaceful Bot
  • Evan The Dev (special mention)

All other bots are distributed to cover the map evenly.

Screenshot 2026-01-28 at 17 39 45

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

sardidefcon

The info.json and image.png files needed to generate the map
All the files needed to run and play the new map "The Box" correctly
Updated to add "The Box" to the list so that the necessary files for this map can be generated
Updated to add the new map "The Box" as a playable map and in the 'Arcade' category
Added map name "The Box"
Added Spanish translation of the map "The Box" > "La Caja"
The map "The Box" has been added to the public match list with a frequency set to '3'
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026

Walkthrough

A new game map called "TheBox" is added to the system across multiple layers: map data files with nation positions, configuration entries registering the map in the game registry and playlist, and localization strings in English and Spanish.

Changes

Cohort / File(s) Summary
Map Data Files
map-generator/assets/maps/thebox/info.json, resources/maps/thebox/manifest.json
Added static map data with nation positions and dimensions for multiple map scales
Configuration & Game Registry
map-generator/main.go, src/core/game/Game.ts, src/server/MapPlaylist.ts
Registered TheBox in map registry, added GameMapType enum member, set playlist frequency to 3
Localization
resources/lang/en.json, resources/lang/es.json
Added map name translations: "The Box" (English), "La Caja" (Spanish)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🎮 Welcome TheBox, a fresh arena gleams,
With nations placed in careful, choreographed schemes,
Through registries and languages it flows,
Bilingual welcome—both English and español goes,
The Box awaits, adventure calls! 📦

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add new map "The Box"' directly and clearly summarizes the main change: introducing a new map to the system.
Description check ✅ Passed The description is well-related to the changeset, providing context about the new map, its features, bot names, translations, and integration points.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Fix all issues with AI agents
In `@map-generator/assets/maps/thebox/info.json`:
- Around line 1-17: The JSON file "info.json" is not formatted according to
project Prettier rules; run the repository formatter (e.g., Prettier) or
reformat the file so the top-level "name" and "nations" array are properly
indented and spaced, ensure consistent quoting/commas, add a final newline, and
save the formatted result to clear the CI Prettier warning.

In `@resources/lang/es.json`:
- Around line 145-146: Revert the changes to the non‑English locale file
resources/lang/es.json by removing the added/modified keys ("halkidiki",
"thebox") so es.json remains unchanged in this PR, and instead ensure the
corresponding key additions/updates are present only in resources/lang/en.json;
leave translation updates for non‑English locales to the dedicated translation
PR flow (the "mls" PRs by Aotumori).
- Around line 145-146: The JSON is invalid because the "halkidiki" entry is
missing a trailing comma before the "thebox" entry; update the
resources/lang/es.json object by adding a comma after the "halkidiki":
"Halkidiki" line so the "thebox": "La Caja" entry is properly separated,
ensuring the file parses as valid JSON.

In `@resources/maps/thebox/manifest.json`:
- Around line 1-124: Run the code formatter (Prettier) on manifest.json to fix
styling CI errors: reformat the JSON so keys/values in the root object ("map",
"map16x", "map4x", "name", "nations") and the arrays of nation objects are
properly spaced/indented, ensure consistent use of double quotes, remove any
trailing commas, and add a final newline; commit the reformatted manifest.json
so CI no longer reports the Prettier warning.

In `@src/core/game/Game.ts`:
- Line 114: The enum member TheBox has spacing that triggers Prettier; update
the enum declaration (specifically the TheBox member in Game enum) to follow
project formatting by adding spaces around the equals sign and ensuring
consistent spacing (e.g., change TheBox= "The Box", to use TheBox = "The Box",)
so the file passes Prettier/CI.

@github-project-automation github-project-automation bot moved this from Triage to Development in OpenFront Release Management Jan 28, 2026
Copy link
Author

@sardidefcon sardidefcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated according to the design parameters established by the community

Copy link
Author

@sardidefcon sardidefcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated according to the design parameters established by the community so that it can be translated from the official translation platform into other languages

Copy link
Author

@sardidefcon sardidefcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to the parameters required by automatic moderation

The Spanish translation has been removed at the request of the community so that it can be edited from the translation platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development

Development

Successfully merging this pull request may close these issues.

1 participant