Show troop count of troop transport boats ⛵

[FloPinguin]

Description:

Troop count display for naval invasion message:

On hover, PlayerInfoOverlay shows the troop count now:

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

FloPinguin

[coderabbitai]

Walkthrough

Adds troop display for TransportShip units in the unit information UI overlay. Updates the naval invasion notification message to include the transported troop count alongside the attacker name. Both changes display existing data in new locations.

Changes

Cohort / File(s)	Summary
Unit Information UI Display src/client/graphics/layers/PlayerInfoOverlay.ts	Adds conditional rendering block to display troops for TransportShip units alongside existing health display using renderTroops(unit.troops())
Naval Invasion Message src/core/execution/TransportShipExecution.ts	Updates incoming naval invasion notification to include troop count in parentheses, e.g., "Naval invasion incoming from <attacker> (<troop_count_render>)"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

• Show Boat troops as "attacking troops" #2393: Directly addresses the feature request to display troop counts on TransportShip units in both the UI info panel and the naval invasion incoming message.

Poem

⛵ Troops now show on the vessel's frame,
Both in the UI and invasion's name,
Transport ships reveal their hidden weight,
A clearer picture of each navy's fate! 🎖️

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: displaying troop count for transport ships in the UI.
Description check	✅ Passed	The description is directly related to the changeset, providing screenshots, confirming testing and translations, and documenting the feature additions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/core/execution/TransportShipExecution.ts`:
- Around line 116-120: Replace the hardcoded English message passed to
mg.displayIncomingUnit with a call to translateText using a translation key
(e.g. "events_display.naval_invasion_inbound") and pass attacker and troops as
params; specifically, in TransportShipExecution where mg.displayIncomingUnit is
invoked (using this.boat.id(), MessageType.NAVAL_INVASION_INBOUND,
this.target.id()), build the message via
translateText("events_display.naval_invasion_inbound", { attacker:
this.attacker.displayName(), troops: renderTroops(this.boat.troops()) }) and use
that instead of the raw string, and ensure you add the corresponding entry to
en.json.

🧹 Nitpick comments (1)

src/core/execution/TransportShipExecution.ts (1)

1-1: Move rendering utilities to shared folder to avoid core → client dependency.

renderTroops is imported from src/client/Utils.ts into core execution code, creating a layering violation. The core layer should not depend on client layer utilities. This pattern affects multiple core files (PlayerImpl.ts, AttackExecution.ts, GameImpl.ts, and others also import renderNumber and translateText from client).

Since these are pure formatting functions (e.g., renderTroops divides by 10 and formats for display), move them to src/core/Utils.ts or a dedicated src/shared/ folder so both core and client layers can use them without breaking layering rules.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Hardcoded message string bypasses translation system.

The TODO on line 116 notes this needs translation. The PR description says all text uses translateText(), but this message is a raw English string. Other calls in this file (like lines 64-70) use translation keys with parameter objects.

Consider using a pattern like:

mg.displayIncomingUnit(
  this.boat.id(),
  translateText("events_display.naval_invasion_inbound", {
    attacker: this.attacker.displayName(),
    troops: renderTroops(this.boat.troops()),
  }),
  MessageType.NAVAL_INVASION_INBOUND,
  this.target.id(),
);

This would need a corresponding entry in en.json.

🤖 Prompt for AI Agents

In `@src/core/execution/TransportShipExecution.ts` around lines 116 - 120, Replace
the hardcoded English message passed to mg.displayIncomingUnit with a call to
translateText using a translation key (e.g.
"events_display.naval_invasion_inbound") and pass attacker and troops as params;
specifically, in TransportShipExecution where mg.displayIncomingUnit is invoked
(using this.boat.id(), MessageType.NAVAL_INVASION_INBOUND, this.target.id()),
build the message via translateText("events_display.naval_invasion_inbound", {
attacker: this.attacker.displayName(), troops: renderTroops(this.boat.troops())
}) and use that instead of the raw string, and ensure you add the corresponding
entry to en.json.

[evanpelle]

thanks!