Skip to content

Add new page for different login providers #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gounux
Copy link
Member

@gounux gounux commented Apr 22, 2025

This PR adds a new page to the doc, regarding different ways of login, using social / third-party providers (SSO).

Here are screenshots of the mermaid sequence diagrams :

  • Web:

image

  • QField / QFieldSync:

image

Add missing participant creation
@gounux gounux force-pushed the add-new-page-for-different-login-ways branch from f3dba95 to 6722739 Compare April 22, 2025 15:23
@lukasgraf
Copy link

@gounux nice work!
As discussed, I have pushed a commit with some additions of mine. I added a bit of introductory text, and extended the first diagram. It now looks like this:

oidc_web_flow

The second flow / diagram is a bit more difficult. I'll see what I can come up with for that one.

@suricactus
Copy link
Collaborator

@lukasgraf @gounux can we move this forward?

@lukasgraf lukasgraf force-pushed the add-new-page-for-different-login-ways branch from 6effc51 to 7e8d30e Compare May 6, 2025 09:22
@lukasgraf
Copy link

@suricactus @gounux I have extended the description of the OIDC flow for QField / QFieldSync.
Diagrams should be rendered properly in the rich diff here on GitHub.
From my point of view, this could be merged like this.

@lukasgraf lukasgraf marked this pull request as ready for review May 6, 2025 09:30
Copy link
Member Author

@gounux gounux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @lukasgraf !

PR description updated.

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly checked for readability and spelling issues. Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants