fix: handle empty rows in bulk upload CSV files and refactor generate… #2389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UrlMappings for lint compliance
seaerchin
reviewed
Aug 4, 2025
Comment on lines
+89
to
+108
| let errorMessage = `Row ${counter + 1}: ` | ||
| if (!acceptableLinkCount) { | ||
| errorMessage += 'exceeds maximum number of links' | ||
| } else if (!onlyOneColumn) { | ||
| errorMessage += 'has more than one column' | ||
| } else if (!isNotBlacklisted) { | ||
| errorMessage += 'contains blacklisted link' | ||
| } else if (!isNotEmpty) { | ||
| errorMessage += 'is empty' | ||
| } else if (!isValidUrl) { | ||
| errorMessage += 'contains invalid url' | ||
| } else if (isNotCircularRedirect) { | ||
| errorMessage += 'contains circular redirect' | ||
| } else if (!noParsingError) { | ||
| errorMessage += 'has parsing error' | ||
| } | ||
| dogstatsd.increment(BULK_VALIDATION_ERROR, 1, 1, [ | ||
| `${BULK_VALIDATION_ERROR_TAGS.isValidUrl}`, | ||
| ]) | ||
| throw new Error(errorMessage) |
Collaborator
There was a problem hiding this comment.
not entirely sure - can there only be 1 error per line? if there's possibly >1, then the formatting might be abit awkward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A number of users have been complaining of failed bulk link uploads because the last row of their uploaded CSV file is empty, and they seem to be unable to debug and fix the issue on their own. It would be nice if Go's backend could help to remove or ignore any extra empty rows when parsing the CSV file, so users are less likely to encounter upload errors
Closes [insert issue #]
#2153
Solution
Handle logic to ignore excel/csv rows which are empty in the end.
Before & After Screenshots
BEFORE:
output.mp4
AFTER:
output1.mp4