Skip to content

core.module.thing(.ide): switch some files from .xtend to .java - #5537

Open
dilyanpalauzov wants to merge 1 commit into
openhab:mainfrom
dilyanpalauzov:things_xtend_java
Open

core.module.thing(.ide): switch some files from .xtend to .java#5537
dilyanpalauzov wants to merge 1 commit into
openhab:mainfrom
dilyanpalauzov:things_xtend_java

Conversation

@dilyanpalauzov

Copy link
Copy Markdown
Contributor

This removes all .xtend files from the org.openhab.core.model.thing.ide bundle and removes the Xtend:compile target there.

Possibly from bundles/org.openhab.core.model.thing.ide/.classpath this can be removed, too:

        <classpathentry kind="src" output="target/classes" path="xtend-gen">
                <attributes>
                        <attribute name="optional" value="true"/>
                        <attribute name="maven.pomderived" value="true"/>
                </attributes>
        </classpathentry>

@dilyanpalauzov
dilyanpalauzov requested a review from a team as a code owner May 4, 2026 11:21
wborn

This comment was marked as low quality.

@wborn wborn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcting the previous review, which was truncated during submission.

AI performed an initial review before manual maintainer review.

The Xtend-to-Java conversions look behavior-preserving, and the Xtext generator configuration looks consistent with keeping Java stubs by default while retaining the existing Xtend validator.

The commit is missing the required Signed-off-by trailer. This PR changes source code and build/generator configuration, so the small patch exception does not apply. Please amend and sign off the commit before merge.

No other issues were found in the current diff beyond the inline .classpath cleanup comment.

<configuration>
<sources>
<source>src-gen</source>
<source>xtend-gen</source>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the corresponding xtend-gen entry also be removed from org.openhab.core.model.thing.ide/.classpath? With the Xtend plugin and this source directory removed from the POM, the Eclipse classpath entry is now stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants