Skip to content

jsr223: Describe parameter of SimpleRule.execute(Map inputs) based on trigger#2582

Open
dilyanpalauzov wants to merge 3 commits into
openhab:mainfrom
dilyanpalauzov:jsr233_execute_inputs
Open

jsr223: Describe parameter of SimpleRule.execute(Map inputs) based on trigger#2582
dilyanpalauzov wants to merge 3 commits into
openhab:mainfrom
dilyanpalauzov:jsr233_execute_inputs

Conversation

@dilyanpalauzov

Copy link
Copy Markdown
Contributor

This clarifies when SimpleRule.execute(Action module, Map<String, ?> inputs) is called, how the content of inputs is built, in general and concrete for TriggerBuilder.withTypeUID("timer.DateTimeTrigger" or "core.ItemStateChangeTrigger").build() triggers.

As noted at dalgwen/openhab-addons#17 (comment) there is per Automation Add-On documentation, how the inputs from fired triggers are presented, but there is no documentation on the OH-JSR223 page, valid for all JSR 223 add-on.

@netlify

netlify Bot commented Oct 6, 2025

Copy link
Copy Markdown

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 4d8021c
🔍 Latest deploy log https://app.netlify.com/projects/openhab-docs-preview/deploys/6952546c440e5c0008e5602a
😎 Deploy Preview https://deploy-preview-2582--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dilyanpalauzov
dilyanpalauzov force-pushed the jsr233_execute_inputs branch 8 times, most recently from 1911923 to 347b3fa Compare October 10, 2025 11:41
@dilyanpalauzov dilyanpalauzov changed the title jsr233: Describe parameter of SimpleRule.execute(Map inputs) based on trigger jsr223: Describe parameter of SimpleRule.execute(Map inputs) based on trigger Oct 10, 2025
@dilyanpalauzov
dilyanpalauzov force-pushed the jsr233_execute_inputs branch 7 times, most recently from fa7dfdb to 640d804 Compare October 14, 2025 13:20
@stefan-hoehn

Copy link
Copy Markdown
Contributor

Please ask these questions first in the forum before creating a PR.

@dilyanpalauzov

Copy link
Copy Markdown
Contributor Author

Why does http://127.0.0.1:8080/rest/module-types/timer.DateTimeTrigger under outputs not contain event, but http://127.0.0.1:8080/rest/module-types/core.ItemStateChangeTrigger under outputs contains event?

Also https://127.0.0.1:8080/rest/module-types/core.ItemStateChangeTrigger contains under outputs : lastStateUpdate and lastStateChange, but https://demo.openhab.org/rest/module-types/core.ItemStateChangeTrigger misses these fields.

The above questions are irrelevant for the current change.

@stefan-hoehn

Copy link
Copy Markdown
Contributor

If the questions are irrelevant for the change, then please remove them from the description.

@dilyanpalauzov

Copy link
Copy Markdown
Contributor Author

I have deleted a comment, but I do not see big value in deleting such comments.

@stefan-hoehn

Copy link
Copy Markdown
Contributor

@florian-h05 I don't know enough to check the written content about jsr223. Would you mind having a look if it is okay from what was added (docu-wise I am happy to check if something should be changed)

@florian-h05
florian-h05 force-pushed the main branch 2 times, most recently from 3ff0c0d to cda5790 Compare July 6, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants