Remove irb from gemspec - #558
Merged
Merged
Conversation
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
changed the title
jimtng
marked this pull request as ready for review
August 13, 2026 06:45
ccutrer
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having irb as a dependency causes bundler to try to install newer version of irb which fails on docker due to its transitive dependency to prism. Prism can't install/build in a standard openhab docker environment.
As of JRuby 10.1.1.0 irb is still bundled, so not having the dependency here makes the addon's default gem installation to work fine.
When using Gemfile, one must explicitly add
gem "irb"to the Gemfile to run the karaf jrubyscripting console (which is how it was before we added the irb dependency to gemspec).Found the past attempts: #438, #415, #422 (issue caused by psych back then, it's prism now)