config_pkg: Update configurations with new flush parameter #2704
Conversation
PR openhwgroup#2691 extended the `cva6_user_cfg_t` struct by two new parameters to control the cache's flush behaviour. Add these new parameters to all configs to fix compilation errors due to incomplete struct literals. Signed-off-by: Nils Wistoff <[email protected]>
|
✔️ successful run, report available here. |
|
@niwis The two parameters are not defined for all configurations (60x and 65x for instance). I think it would be better to define it for all. |
|
@JeanRochCoulon sure, done |
core/include/cv32a60x_config_pkg.sv
Outdated
| @@ -88,8 +91,8 @@ package cva6_config_pkg; | |||
| DcacheByteSize: unsigned'(2028), | |||
| DcacheSetAssoc: unsigned'(2), | |||
| DcacheLineWidth: unsigned'(128), | |||
| DcacheFlushOnFence: bit'(0), | |||
| DcacheInvalidateOnFlush: bit'(0), | |||
| DcacheFlushOnFence: bit'(CVA6ConfigDcacheFlushOnFence), | |||
There was a problem hiding this comment.
| DcacheFlushOnFence: bit'(CVA6ConfigDcacheFlushOnFence), | |
| DcacheFlushOnFence: bit'(1'b0), |
There was a problem hiding this comment.
We are trying to remove the localparam from config_pkg to avoid bugs, because a discrepancy can occur between localparam and cva6config parameter (if driven from outside).
There was a problem hiding this comment.
sorry @JeanRochCoulon, I guess I misunderstood your previous request. 60x and 65x already define this parameter in their cva6_cfg struct on master, what else should I do then?
cva6/core/include/cv32a60x_config_pkg.sv
Lines 91 to 92 in cb5c623
I'll revert the previous commit
There was a problem hiding this comment.
My bad, I was not aware that the two parameters were already present in 60x and 65x. I will merge
|
❌ failed run, report available here. |
Signed-off-by: Nils Wistoff <[email protected]>
|
✔️ successful run, report available here. |
|
❌ failed run, report available here. |
#2691 extended the
cva6_user_cfg_tstruct by two new parameters to control the cache's flush behaviour. Add these new parameters to all configs to fix compilation errors due to incomplete struct literals.