Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify batch management in the Wallet when the new batch of the credentials was received #452

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

clarify batch management in the Wallet when the new batch of the credentials was received #452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ee0440
clarify batch management
Jan 22, 2025
d74abf6
Apply suggestions from code review
Sakurann Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions openid-4-verifiable-credential-issuance-1_0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,6 +1101,8 @@ If the Client requested an encrypted response by including the `credential_respo

If the Credential Response is not encrypted, the media type of the response MUST be set to `application/json`.

When the Wallet receives a new batch of Credentials containing a specific Credential Dataset, the Wallet SHOULD delete any Credentials containing the same Credential Dataset it might have received previously.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is slightly over specific - it doesn't give any advice for the case where the issuer doesn't support batch issuance, nor it is necessarily helpful in the case where the wallet wants a batch of 10 and the issuer only supports batches of 5 (the wallet would hence ask for two batches of 5 and definitely wouldn't delete the first batch of 5 when it got the second batch of 5...).

Maybe this is more generic advice?

Suggested change
When the Wallet receives a new batch of Credentials containing a specific Credential Dataset, the Wallet SHOULD delete any Credentials containing the same Credential Dataset it might have received previously.
When the Wallet receives new Credentials containing a specific Credential Dataset, the Wallet SHOULD delete any Credentials containing the same Credential Dataset it received in previous sessions.

(I'm not sure "session" is well defined but can't think of another phrase that means "delete credentials you received a while ago but not ones you received 10 seconds ago".)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When the Wallet receives a new batch of Credentials containing a specific Credential Dataset, the Wallet SHOULD delete any Credentials containing the same Credential Dataset it might have received previously.
When the Wallet receives new Credentials containing a specific Credential Dataset, the Wallet SHOULD delete any Credentials containing the same Credential Dataset it received in previous issuance responses if those Credentials are no longer valid.


The following parameters are used in the JSON-encoded Credential Response body:

* `credentials`: OPTIONAL. Contains an array of one or more issued Credentials. It MUST NOT be used if the `transaction_id` parameter is present. The elements of the array MUST be objects. This specification defines the following parameters to be used inside this object:
Expand Down