make credential_signing_alg_values_supported type and values format specific #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… format specific and introduced credential_signing_crv_values_supported for mdocs
awoie
changed the title
Sakurann
approved these changes
Feb 17, 2025
Sakurann
requested review from
danielfett,
c2bo,
tplooker,
paulbastian and
bc-pi
davidz25
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
I think this is an improvement, thanks.
(As an aside, would be nice if we could depend on fully specified algorithms - that way we wouldn't need e.g. credential_signing_crv_values_supported. But I don't think we can add that dependency.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
credential_signing_alg_values_supportedformat specificcredential_signing_alg_values_supportedto COSE algorithm values for mdocscredential_signing_crv_values_supportedto mdoc format because of polymorphic COSE algorithm identifiersFixes #354 and fixes #303
Note that this is also how it is used in 23220-3 atm.