Improve text on effective Client Identifiers #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
reviewed
Feb 25, 2025
Sakurann
reviewed
Feb 25, 2025
Sakurann
reviewed
Feb 25, 2025
| - the `nonce` claim MUST be the value of `nonce` from the Authorization Request; | ||
| - the `aud` claim MUST be the value of the Client Identifier; | ||
|
|
||
| Note that for an unsigned Authorization Request over the DC API, the `client_id` parameter is not used. Instead, the effective Client Identifier is derived from the Origin, as described in (#dc_api_request). |
There was a problem hiding this comment.
I would keep below clarification. it feels important to repeat that client_id is omitted in unsigned dc api requests
Note that for an unsigned Authorization Request over the DC API, the
client_idparameter is not used.
There was a problem hiding this comment.
I was hoping that the addition of 2059 would make that unnecessary. I would like to make it clear that for DC API unsigned, the client_id is constructed by the wallet and not have to repeat that for every credential format
Sakurann
requested changes
Feb 25, 2025
Co-authored-by: Kristina <[email protected]>
|
I guess with the resolution to remove client id for dc api, we can close this? |
|
superceded by #448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #399
I increased the scope of the PR slightly to also change the text about the web-origin client id scheme which doesn't seem to be correct right now (see comment in #399). Happy to remove if we don't agree on that part.